Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default grouping step for new line chart #276

Closed
acelaya opened this issue May 31, 2020 · 0 comments · Fixed by #278
Closed

Fix default grouping step for new line chart #276

acelaya opened this issue May 31, 2020 · 0 comments · Fixed by #278
Labels
bug Something isn't working
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented May 31, 2020

Shlink web client version

  • Version: 2.5.0
  • How do you use shlink-web-client: All

Summary

Shlink v2.5.0 introduces a new line chart where you can see how many visits a link received during time.

It allows to show visits per hour, day, week and month, being the last one the default value.

However, that makes no sense for too young short URLs, as it only shows one dot for a long time.

Change the default value to be dynamic, following this logic:

  • Default to hourly when the short URL is younger than 2 days.
  • Default to daily when the short URL is between 2 days and 1 month old.
  • Default to weekly when the short URL is between 1 and 6 months.
  • Default to monthly for short URLs older than 6 months.

The reference date should be the one in which the first visit occured.

@acelaya acelaya added the bug Something isn't working label May 31, 2020
@acelaya acelaya added this to the 2.5.1 milestone May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant