Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.x.x of the library is not compatible with Angular 4 #385

Closed
erzaehlsalex opened this issue Aug 15, 2017 · 3 comments
Closed

Version 4.x.x of the library is not compatible with Angular 4 #385

erzaehlsalex opened this issue Aug 15, 2017 · 3 comments

Comments

@erzaehlsalex
Copy link
Contributor

  • I'm submitting a ...
    [x] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

The library is no more compatible with Angular 4. I'm using Angular 4.x and I installed the version 4.0.0-beta.1 of the ngx-modialog library. Now the following stack trace appears when I'm trying to open a modal.

ERROR TypeError: __WEBPACK_IMPORTED_MODULE_0__angular_core__.Injector.create is not a function at DOMOverlayRenderer.webpackJsonp../node_modules/ngx-modialog/bundle/ngx-modialog.es5.js.DOMOverlayRenderer.render

The problem is that Injector.create was introduced in Angular 5 beta 3. So right now, it is not possible to use the library with an angular version below 5 beta 3. Is there a workaround that you could provide by any chance?

Thanks in advance

@shlomiassaf
Copy link
Owner

shlomiassaf commented Aug 15, 2017

The problem with angular 5 is deprecating support for ReflectiveInjector which is a big thing since the library used ReflectiveInjector when creating dialogs.

Creating a deprecation path from 4 to 3 is time consuming so I couldn't support that.

There is a tag for version 3.0.2, if you want to add some of the fixes created since then we can do that by creating a branch and PR's into it. I will publish the npm package for that...

This is why version 4 is beta

@shlomiassaf shlomiassaf changed the title Library is no more compatible with Angular 4 Version 4.x.x of the library is not compatible with Angular 4 Aug 15, 2017
@erzaehlsalex
Copy link
Contributor Author

Great, can you please create a new branch for that? So I can fix #379 on this branch and commit it, so you can publish that on npm. This would be awesome!

@shlomiassaf
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants