From 1d3d663dedf8f4daf3fd120daf7a6e5ab08c4fee Mon Sep 17 00:00:00 2001 From: mkucmus Date: Mon, 15 May 2023 23:50:41 +0200 Subject: [PATCH 1/2] fix(nuxt3-module): remove package parser --- packages/nuxt3-module/build.config.ts | 7 +------ packages/nuxt3-module/package.json | 1 - packages/nuxt3-module/src/utils.ts | 12 +++++++----- pnpm-lock.yaml | 11 +---------- 4 files changed, 9 insertions(+), 22 deletions(-) diff --git a/packages/nuxt3-module/build.config.ts b/packages/nuxt3-module/build.config.ts index d577793db..be011f82a 100644 --- a/packages/nuxt3-module/build.config.ts +++ b/packages/nuxt3-module/build.config.ts @@ -7,10 +7,5 @@ export default defineBuildConfig({ cjsBridge: true, }, declaration: true, - externals: [ - "@nuxt/schema", - "@nuxt/kit", - "@shopware-pwa/composables-next", - "package-json-parser", - ], + externals: ["@nuxt/schema", "@nuxt/kit", "@shopware-pwa/composables-next"], }); diff --git a/packages/nuxt3-module/package.json b/packages/nuxt3-module/package.json index 407a80256..42c8acba0 100644 --- a/packages/nuxt3-module/package.json +++ b/packages/nuxt3-module/package.json @@ -48,7 +48,6 @@ "@nuxt/devtools": "^0.4.6", "@nuxt/schema": "^3.4.3", "eslint-config-shopware": "workspace:*", - "package-json-parser": "^2.2.0", "tsconfig": "workspace:*", "typescript": "^5.0.4", "unbuild": "^1.2.1" diff --git a/packages/nuxt3-module/src/utils.ts b/packages/nuxt3-module/src/utils.ts index 850bde81c..254a42f7f 100644 --- a/packages/nuxt3-module/src/utils.ts +++ b/packages/nuxt3-module/src/utils.ts @@ -2,7 +2,6 @@ import { Nuxt } from "@nuxt/schema"; import { resolve, dirname } from "path"; import { fileURLToPath } from "node:url"; import { promises as fs, constants as FS_CONSTANTS } from "node:fs"; -import packageJson from "package-json-parser"; type DEPENDENCY = "@shopware-pwa/api-client" | "@shopware-pwa/composables-next"; @@ -16,15 +15,18 @@ export async function isDependencyInstalledLocally( ) { try { const projectPackageJsonPath = resolve(rootDir, "package.json"); - const packageJsonDefinition = packageJson.json(projectPackageJsonPath); + const packageJson = JSON.parse( + await fs.readFile(projectPackageJsonPath, "utf8") + ); + if ( - packageJsonDefinition?.dependencies?.[dependency] || - packageJsonDefinition?.devDependencies?.[dependency] + packageJson?.dependencies?.[dependency] || + packageJson?.devDependencies?.[dependency] ) { return true; } } catch (error) { - console.error("nuxt3-module: unable to check local dependencies"); + console.error("nuxt3-module: unable to check local dependencies", error); } return false; } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7968017f0..2931554da 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -593,9 +593,6 @@ importers: eslint-config-shopware: specifier: workspace:* version: link:../eslint-config-shopware - package-json-parser: - specifier: ^2.2.0 - version: 2.2.0 tsconfig: specifier: workspace:* version: link:../tsconfig @@ -5618,7 +5615,7 @@ packages: /@types/node-fetch@2.6.3: resolution: {integrity: sha512-ETTL1mOEdq/sxUtgtOhKjyB2Irra4cjxksvcMUR5Zr4n+PxVhsCD9WS46oPbHL3et9Zde7CNRr+WUNlcHvsX+w==} dependencies: - '@types/node': 14.18.33 + '@types/node': 18.16.9 form-data: 3.0.1 dev: true @@ -14514,12 +14511,6 @@ packages: netmask: 2.0.2 dev: true - /package-json-parser@2.2.0: - resolution: {integrity: sha512-yrLg4z/NeyIYTGjH/QFQBmobZUF1FkuxdJy09j7l4PiPEjkxbtRNk1dl88jRvKgW5DGaqQ3azClJNqmQNzPZyg==} - dependencies: - type-fest: 0.21.3 - dev: true - /pacote@15.1.3: resolution: {integrity: sha512-aRts8cZqxiJVDitmAh+3z+FxuO3tLNWEmwDRPEpDDiZJaRz06clP4XX112ynMT5uF0QNoMPajBBHnaStUEPJXA==} engines: {node: ^14.17.0 || ^16.13.0 || >=18.0.0} From 46a6601d4e0c4870cfb1db03a22b9f58bdf37975 Mon Sep 17 00:00:00 2001 From: mkucmus Date: Mon, 15 May 2023 23:51:48 +0200 Subject: [PATCH 2/2] chore: changeset --- .changeset/khaki-seas-sin.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/khaki-seas-sin.md diff --git a/.changeset/khaki-seas-sin.md b/.changeset/khaki-seas-sin.md new file mode 100644 index 000000000..5abfe2405 --- /dev/null +++ b/.changeset/khaki-seas-sin.md @@ -0,0 +1,5 @@ +--- +"@shopware-pwa/nuxt3-module": patch +--- + +Package.json parser removed