Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write benchmarks for TLS #170

Closed
rukai opened this issue Sep 3, 2021 · 3 comments
Closed

Write benchmarks for TLS #170

rukai opened this issue Sep 3, 2021 · 3 comments
Assignees
@rukai

Comments

@rukai
Copy link
Member

rukai commented Sep 3, 2021

No description provided.

@rukai rukai mentioned this issue Sep 3, 2021
Merged
3 tasks
@rukai
Copy link
Member Author

rukai commented Sep 28, 2021

Blocked by this issue: bheisler/criterion.rs#514
A work around might be to split the benchmarks into seperate .rs files and therefore result in separate benchmark executables

@rukai rukai self-assigned this Sep 28, 2021
@rukai
Copy link
Member Author

rukai commented Sep 28, 2021

Oh...
I realized I just confused myself somehow, probably by some intermittent failure.
There is no issue with side effects as our destructors do run before moving to the next benchmark

The only problem is that running a single benchmark takes almost as long as running every benchmark, but that wont exactly block me from writing new ones.

@rukai
Copy link
Member Author

rukai commented Oct 4, 2021

Closed by #221

@rukai rukai closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rukai rukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rukai