list improvements (#671)

* list improvements * list improvements * list improvements * list improvements * list improvements * list improvements * list improvements
showtime-xyz · Jan 10, 2022 · 6ae0fc2 · 6ae0fc2
1 parent 7a674ce
commit 6ae0fc2
Show file tree

Hide file tree

Showing 6 changed files with 121 additions and 328 deletions.
diff --git a/packages/app/components/feed.tsx b/packages/app/components/feed.tsx
@@ -1,7 +1,6 @@
 import { useCallback, useRef, useState } from "react";
 import { Platform } from "react-native";
 import { useBottomTabBarHeight } from "@react-navigation/bottom-tabs";
-import { useScrollToTop } from "@react-navigation/native";
 import { useActivity } from "app/hooks/api-hooks";
 
 import { View, Spinner, Text } from "design-system";
@@ -101,10 +100,6 @@ const CreationList = () => {
     []
   );
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -126,7 +121,6 @@ const CreationList = () => {
       refreshing={isRefreshing}
       onRefresh={refresh}
       onEndReached={fetchMore}
-      ref={listRef}
       onEndReachedThreshold={0.6}
       removeClippedSubviews={Platform.OS !== "web"}
       numColumns={1}
@@ -149,10 +143,6 @@ const LikesList = () => {
     []
   );
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -174,7 +164,6 @@ const LikesList = () => {
       refreshing={isRefreshing}
       onRefresh={refresh}
       onEndReached={fetchMore}
-      ref={listRef}
       onEndReachedThreshold={0.6}
       removeClippedSubviews={Platform.OS !== "web"}
       numColumns={1}
@@ -197,10 +186,6 @@ const CommentsList = () => {
     []
   );
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -222,7 +207,6 @@ const CommentsList = () => {
       refreshing={isRefreshing}
       onRefresh={refresh}
       onEndReached={fetchMore}
-      ref={listRef}
       onEndReachedThreshold={0.6}
       removeClippedSubviews={Platform.OS !== "web"}
       numColumns={1}
@@ -245,10 +229,6 @@ const FollowsList = () => {
     []
   );
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -270,7 +250,6 @@ const FollowsList = () => {
       refreshing={isRefreshing}
       onRefresh={refresh}
       onEndReached={fetchMore}
-      ref={listRef}
       onEndReachedThreshold={0.6}
       removeClippedSubviews={Platform.OS !== "web"}
       numColumns={1}
@@ -293,10 +272,6 @@ const AllActivityList = () => {
     []
   );
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -318,7 +293,6 @@ const AllActivityList = () => {
       refreshing={isRefreshing}
       onRefresh={refresh}
       onEndReached={fetchMore}
-      ref={listRef}
       onEndReachedThreshold={0.6}
       removeClippedSubviews={Platform.OS !== "web"}
       numColumns={1}

diff --git a/packages/app/components/trending.tsx b/packages/app/components/trending.tsx
@@ -1,4 +1,4 @@
-import { useCallback, useMemo, useRef, useState } from "react";
+import { useCallback, useMemo, useState } from "react";
 import {
   View,
   Spinner,
@@ -11,7 +11,6 @@ import {
 } from "design-system";
 import { tw } from "design-system/tailwind";
 import { useTrendingCreators, useTrendingNFTS } from "../hooks/api-hooks";
-import { useScrollToTop } from "@react-navigation/native";
 import { useBottomTabBarHeight } from "@react-navigation/bottom-tabs";
 import { Dimensions, Platform } from "react-native";
 import { Video } from "expo-av";
@@ -130,10 +129,6 @@ const CreatorsList = ({
     return <CreatorPreview creator={item} />;
   }, []);
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -166,7 +161,6 @@ const CreatorsList = ({
         refreshing={isRefreshing}
         onRefresh={refresh}
         onEndReached={fetchMore}
-        ref={listRef}
         onEndReachedThreshold={0.6}
         removeClippedSubviews={Platform.OS !== "web"}
         ListHeaderComponent={ListHeaderComponent}
@@ -201,10 +195,6 @@ const NFTSList = ({
 
   const renderItem = useCallback(({ item }) => <Media item={item} />, []);
 
-  const listRef = useRef(null);
-
-  useScrollToTop(listRef);
-
   const ListFooterComponent = useCallback(
     () => <Footer isLoading={isLoadingMore} />,
     [isLoadingMore]
@@ -241,7 +231,6 @@ const NFTSList = ({
         refreshing={isRefreshing}
         onRefresh={refresh}
         onEndReached={fetchMore}
-        ref={listRef}
         onEndReachedThreshold={0.6}
         removeClippedSubviews={Platform.OS !== "web"}
         ListHeaderComponent={ListHeaderComponent}

diff --git a/packages/design-system/tabs/index.tsx b/packages/design-system/tabs/index.tsx
@@ -1,6 +1,2 @@
 export { Tabs, useTabsContext, useTabIndexContext } from "./tablib";
-export {
-  TabItem,
-  PullToRefresh,
-  SelectedTabIndicator,
-} from "./tablib/components";
+export { TabItem, SelectedTabIndicator } from "./tablib/components";