Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Bug bash fixes #574

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Bug bash fixes #574

merged 2 commits into from
Dec 8, 2021

Conversation

m1guelpf
Copy link

@m1guelpf m1guelpf commented Dec 6, 2021

No description provided.

@m1guelpf m1guelpf self-assigned this Dec 6, 2021
@vercel
Copy link

vercel bot commented Dec 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/HDxeeYHKzFV9icCty1Pkovog8LfJ
✅ Preview: https://showtime-git-marketplace-bug-bash-showtime.vercel.app

fontanierh
fontanierh reviewed Dec 6, 2021
View reviewed changes
yarn.lock Outdated
@@ -34,14 +34,14 @@
dependencies:
"@babel/highlight" "^7.10.4"

"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.14.5", "@babel/code-frame@^7.15.8", "@babel/code-frame@^7.5.5", "@babel/code-frame@^7.8.3":
"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.14.5", "@babel/code-frame@^7.15.8":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the same pb locally. yarn.lock shouldn't randomly change when we yarn install, anyone knows why this is happening ? @axeldelafosse maybe ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Do you have the exact same diff for yarn.lock?

fontanierh
fontanierh approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, except the yarn.lock (not sure it should be changed by this PR)

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-574&sdkVersion=43.0.0

Comment ID: 987332138

@axeldelafosse axeldelafosse self-requested a review December 7, 2021 21:14
axeldelafosse
axeldelafosse suggested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@axeldelafosse axeldelafosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the yarn.lock changes please? Need to investigate this in another PR. Feel free to reach out on Discord. Looks like Nishan and Lois don't have this issue

@m1guelpf m1guelpf merged commit 1d2393e into staging Dec 8, 2021
@m1guelpf m1guelpf deleted the marketplace-bug-bash branch December 8, 2021 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axeldelafosse axeldelafosse axeldelafosse requested changes

@TatisLois TatisLois TatisLois approved these changes

@fontanierh fontanierh fontanierh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1guelpf @axeldelafosse @TatisLois @fontanierh