Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Small Yarn Workspace Fix #578

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Small Yarn Workspace Fix #578

merged 1 commit into from
Dec 8, 2021

Conversation

TatisLois
Copy link
Contributor

In the root directory the command yarn dev:storybook:react-native would throw an error and not run the app. This was not the case for the other apps. I realized after debugging that the workspace name for apps/storybook-react-native was mismatching the convention used in the root package.json.

  • Update apps/storybook-react-native to use @showtime scoping convention
  • Add a utility command to rm all monorepo node_modules at once (I found myself doing this often when debugging the workspace) (reference: http://man.he.net/?topic=find&section=all)

Might have to run yarn in the root to pick up change`

@vercel
Copy link

vercel bot commented Dec 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/CiQVEU291gJKhjwiBbJNWN7NhACn
✅ Preview: https://showtime-git-fix-react-native-workspace-showtime.vercel.app

Copy link
Contributor

@axeldelafosse axeldelafosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Nice catch! Thank you

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-578&sdkVersion=43.0.0

Comment ID:

@TatisLois TatisLois merged commit 8c410bb into staging Dec 8, 2021
@TatisLois TatisLois deleted the fix/react-native-workspace branch December 8, 2021 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants