Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: add Input component #587

Merged
merged 5 commits into from
Dec 13, 2021
Merged

feat: add Input component #587

merged 5 commits into from
Dec 13, 2021

Conversation

intergalacticspacehighway
Copy link
Collaborator

This PR adds an Input component as displayed in Figma Link 1 Link 2

Changes

  • Label component now acts as a Text instead of View and accepts all of our design system Text props. (See text.web.tsx). This approach is recommended here
  • Added hidden html native input on web so it can respond to htmlFor prop in label
  • Extracted colors from tailwind/config and moved to a separate file so it can be used for non-style props. e.g. selectionColor or maybe gradients in future.

Features

Input component

  • API is kept in such a way that can maximize productivity and be easier to maintain. It's less flexible (you can't control where the helper, label will be displayed) but I guess this serves our purpose.
  • Accessibile on all the platforms 🚀

Fixes

  • fontWeight 600 points to semi-bold instead of bold.

P.S. There are some small changes in Text component. Let me know if those are not very obvious or if there's a better way to implement them!

@vercel
Copy link

vercel bot commented Dec 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/HMiY9Hu2bjG5Qm6pnqNvA2F2RMJ3
✅ Preview: https://showtime-git-input-showtime.vercel.app

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-587&sdkVersion=43.0.0

Comment ID: 990589586

@intergalacticspacehighway
Copy link
Collaborator Author

storybook-react's document.tsx is not transpiling which is leading to build failure. Looking into it.

@intergalacticspacehighway intergalacticspacehighway changed the title Input feat: add Input component Dec 13, 2021
Copy link
Contributor

@axeldelafosse axeldelafosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants