Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix: add expo next plugin in storybook react #589

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

intergalacticspacehighway
Copy link
Collaborator

The storybook-react has a custom _document.tsx file which imports from @expo package which are not transpiled and leads to build error on vercel. This PR aims to fix that.

@vercel
Copy link

vercel bot commented Dec 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/BFsWxYATBqsdBgYamFYBZKc3eLuE
✅ Preview: https://showtime-git-fix-vercel-build-failure-showtime.vercel.app

@axeldelafosse
Copy link
Contributor

Nice! I was about to push this fix too. The thing is we shouldn't even have to build this Next.js app. Might be worth removing the build script in this app. What do you think?

@axeldelafosse
Copy link
Contributor

Also I guess this is a Turborepo misconfiguration, it shouldn't try to build this app.

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-589&sdkVersion=43.0.0

Comment ID: 990747446

@intergalacticspacehighway
Copy link
Collaborator Author

yeah, right. We don't need to build Next.js app I guess. AFAIK storybook starts it's own server and has it's own build script, so does it use our custom document.tsx or is it just kept for testing?

@axeldelafosse
Copy link
Contributor

so does it use our custom document.tsx or is it just kept for testing

Nope I don't think so. I added this earlier this week when working on the fonts loading but I could've removed it. Let's keep it now that it's here, it's better for consistency

@axeldelafosse axeldelafosse merged commit c9cdc4a into staging Dec 10, 2021
@m1guelpf m1guelpf deleted the fix-vercel-build-failure branch January 26, 2022 02:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants