Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

add All Time option on trending page #590

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Dec 10, 2021

Why

Frontend for SHOW2-87 Add "All Time" option to Trending page

Backend counterpart: https://github.com/tryshowtime/stbackend/pull/147 + https://github.com/tryshowtime/stbackend/pull/148

How

Simply add a GridTab component allowing to set leaderboardDays to 10k

Screenshot 2021-12-10 at 19 13 18

Test

Only tested manually

@vercel
Copy link

vercel bot commented Dec 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/5zqR8eBjYHFtzxBdNczwp3SxXzRd
✅ Preview: https://showtime-git-feat-add-all-time-trending-showtime.vercel.app

@github-actions
Copy link

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-590&sdkVersion=43.0.0

Comment ID:

@fontanierh fontanierh requested a review from TatisLois December 10, 2021 18:34
Copy link
Contributor

@TatisLois TatisLois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TatisLois
Copy link
Contributor

Not in scope for this PR but for some reason I only see one creator on the all time + nothing happens when I click Show More 🤔

Screenshot for reference

Screen Shot 2021-12-10 at 12 34 08 PM

@TatisLois
Copy link
Contributor

Not in scope for this PR but for some reason I only see one creator on the all time + nothing happens when I click Show More 🤔

Screenshot for reference

Screen Shot 2021-12-10 at 12 34 08 PM

To close the comment feedback loop, this won't be an issue cc slack -> https://showtime-rq88331.slack.com/archives/C02Q0E4PBD0/p1639162363058500?thread_ts=1639161720.051500&cid=C02Q0E4PBD0

@m1guelpf m1guelpf merged commit 3b71085 into staging Dec 11, 2021
@m1guelpf m1guelpf deleted the feat/add-all-time-trending branch December 11, 2021 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants