Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Feature/show2 261 spinner #597

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Feature/show2 261 spinner #597

merged 3 commits into from
Dec 13, 2021

Conversation

intergalacticspacehighway
Copy link
Collaborator

This PR adds Spinner component

Checklist

  • Dark mode
  • iOS
  • Web
  • Android
  • Accessibility

Demo

Screen.Recording.2021-12-14.at.12.21.51.AM.mov

@linear
Copy link

linear bot commented Dec 13, 2021

SHOW2-261 Spinner

Design link

%F0%9F%93%9A UI-Library (Figma)

@vercel
Copy link

vercel bot commented Dec 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/J3JEbABJ13xxZEhVhisZvuQX8Wkn
✅ Preview: https://showtime-git-feature-show2-261-spinner-showtime.vercel.app

axeldelafosse
axeldelafosse approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@axeldelafosse axeldelafosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

packages/design-system/spinner/spinner.stories.tsx
} as Meta

const Container = (props: any) => {
return <View tw={'dark:bg-gray-900 p-10 bg-white'}>{props.children}</View>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous PR, I guess we can export this component or maybe even set the background color in the Storybook decorators via a provider?

Nit pick but we can use tw="" instead of tw={''}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. Will make it in the next component.

@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-597&sdkVersion=43.0.0

Comment ID: 992780209

@intergalacticspacehighway intergalacticspacehighway merged commit a54c6c2 into staging Dec 13, 2021
@intergalacticspacehighway
Copy link
Collaborator Author

Pushed a small checkbox focus styling change in this one. It's a small change so not bothering with a PR.

@intergalacticspacehighway intergalacticspacehighway deleted the feature/show2-261-spinner branch December 13, 2021 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axeldelafosse axeldelafosse axeldelafosse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intergalacticspacehighway @axeldelafosse