Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

update formatting config and reformat whole codebase (#yolo) #619

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Dec 21, 2021

Why

discussed here: we prefer using default settings for formatting, because otherwise everyone has their personal preferences and we end up having non-productive arguments.

How

  • remove prettierrc.js
  • make eslint config extend "plugin:prettier/recommended"
  • remove specific formatting rules from eslint config
  • add .prettierignore file
  • use prettier --write .

impact

None functionality-wise. Might have to setup your vscode to use format via eslint ? Worked out of the box on my end with autofix on save

Test Plan

Manuel check that the app still builds

@vercel
Copy link

vercel bot commented Dec 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/35jgbqY2YR5ctCQbSErK5KP6ALe7
✅ Preview: https://showtime-git-enh-formatting-showtime.vercel.app

@fontanierh fontanierh marked this pull request as ready for review December 21, 2021 17:27
@github-actions
Copy link

github-actions bot commented Dec 21, 2021

PR Preview

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-619&sdkVersion=44.0.0

Comment ID: 998966810

@github-actions
Copy link

github-actions bot commented Dec 21, 2021

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-619&sdkVersion=44.0.0

Comment ID: 998985907

Copy link
Contributor

@TatisLois TatisLois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Feel free to merge after these conflicts are resolved!

.github/workflows/expo-preview.yml
apps/storybook-react-native/.storybook/storybook.requires.js
packages/app/screens/login.tsx
packages/design-system/bottom-sheet/index.tsx
packages/design-system/modal/header.tsx
packages/design-system/modal/index.tsx

@github-actions
Copy link

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-619&sdkVersion=44.0.0

Comment ID:

@m1guelpf m1guelpf deleted the enh/formatting branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants