Feature/show2 233 segmented control #625
Conversation
…howtime/showtime-frontend into feature/show2-233-segmented-control
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/showtime/showtime/8vLy1SrGdiYUb9XBhdc6Sc2kVm69 |
| import {colors} from "design-system/tailwind/colors"; | ||
| import {useIsDarkMode} from "design-system/hooks"; | ||
| import {tw} from "design-system/tailwind"; |
There was a problem hiding this comment.
There is no spaces here (should be { colors }), maybe your VSCode ESLint config is not correct? Cf #624
There was a problem hiding this comment.
oh my bad. I had format on save disabled. Pushed the fix
PR Preview - StorybookThis pull request preview deployment is now available. ✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-625&sdkVersion=44.0.0 Comment ID: 1000255504 |
PR Preview - AppThis pull request preview deployment is now available. ✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-625&sdkVersion=44.0.0 Comment ID: 1000259103 |
|
I'm not a big fan of the pressed label color, it's a little bit weird isn't it? Upload.from.GitHub.for.iOS.MOV |
|
Would be cool to automatically trigger a new build on EAS when we add a native dependency! |
Screen.Recording.2021-12-23.at.6.16.20.PM.movTrue. It's using TouchableOpacity for web/android, no way to customise it 🙁. On iOS it doesn't look that bad. |
PR Preview - Storybook on Chromatic |
|
Ah! Maybe we can patch it to use Pressable instead? It's not a blocker tho, accepted the change on Chromatic, all green ✅ |
|
Cool. Added the patch with PressableScale! |
|
Perfect 🤩 |
intergalacticspacehighway
deleted the
feature/show2-233-segmented-control
branch
Why
How
Test Plan