Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Upgrade expo-dev-client #631

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Upgrade expo-dev-client #631

merged 1 commit into from
Dec 28, 2021

Conversation

axeldelafosse
Copy link
Contributor

Why

Expo released a new version of the development client https://blog.expo.dev/expo-dev-client-0-8-0-7116c1945253

How

  • Upgraded expo-dev-client
  • Also upgraded expo-updates for the Storybook app (was just upgraded in the app too)

Test Plan

  • Build and run the apps successfully

@vercel
Copy link

vercel bot commented Dec 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/AaYXBnKjH5EPqTYNxVegwfJQAEhF
✅ Preview: https://showtime-git-upgrade-dev-client-showtime.vercel.app

@github-actions
Copy link

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-631&sdkVersion=44.0.0

Comment ID:

@github-actions
Copy link

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-631&sdkVersion=44.0.0

Comment ID:

Copy link
Contributor

@TatisLois TatisLois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Interesting that app/expo/index.js didn’t prettify the quotes. Not a big deal just a curious observation

@axeldelafosse
Copy link
Contributor Author

Interesting that app/expo/index.js didn’t prettify the quotes

Expo actually check for and adds this line with single quotes. So I kept this one otherwise it would keep adding it

@axeldelafosse axeldelafosse merged commit 1b5bae7 into staging Dec 28, 2021
@m1guelpf m1guelpf deleted the upgrade-dev-client branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants