fix: ios menu error #633
fix: ios menu error #633
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/showtime/showtime/Hc9zk8aL5VJcz8Zu22iQreSq4M6N |
PR Preview - StorybookThis pull request preview deployment is now available. ✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-633&sdkVersion=44.0.0 Comment ID: 1002118973 |
PR Preview - AppThis pull request preview deployment is now available. ✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-633&sdkVersion=44.0.0 Comment ID: 1002121533 |
package.json
Outdated
| @@ -45,7 +45,8 @@ | |||
| "clean": "yarn clean:turbo & yarn clean:node-modules", | |||
| "clean:turbo": "rm -rf ./node_modules/.cache/turbo", | |||
| "clean:node-modules": "find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +", | |||
| "postinstall": "patch-package" | |||
| "postinstall": "patch-package", | |||
| "nuke": "yarn clean && rm -rf apps/storybook-react-native/android && rm -rf apps/storybook-react-native/ios && rm -rf apps/expo/android && rm -rf apps/expo/ios" | |||
There was a problem hiding this comment.
Awesome addition!
My nitpick are not blockers but do you think clean:mobile might be a more aligned script name? Also if you have the time it could be helpful to add the new script to the script command section of the readme.
There was a problem hiding this comment.
Yeah I agree about naming. I'll go for clean:native as it is removing the native iOS and Android folders.
There was a problem hiding this comment.
Good suggestion! Updated and added in readme
PR Preview - Storybook on Chromatic |
Why
Fixes the below error appearing due to context menu library and adds a
nukescriptTest Plan