Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Resolve undefined variable for listed by value #636

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

TatisLois
Copy link
Contributor

Why

item is not defined in the BuyModal component and causes the buying flow to break. The value representing item is passed in as a prop named token. Naming/Data flow will be an area of improvement when the modals are refactored + types will help.

I also left a small comment in apps/next-react/src/components/TokenGridV5.js mentioning that the value of token={buyModal} is the same as an item in the items list.

How

Update references to item to token

Test Plan

Tested locally by going through a few buy flows

CALL OUT

Eslint should have caught this and when I tested it out, I had inconsistent results 😱 needs to be looked into...

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/HwoJSvskTtAadVSzTvYo5BRiy5HW
✅ Preview: https://showtime-git-fix-buy-modal-listedby-showtime.vercel.app

@github-actions
Copy link

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-636&sdkVersion=44.0.0

Comment ID:

@github-actions
Copy link

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-636&sdkVersion=44.0.0

Comment ID:

@TatisLois
Copy link
Contributor Author

Going to make the call to merge without approvals because of time sensitively -> https://showtime-rq88331.slack.com/archives/C02Q0E4PBD0/p1640890547246400

@TatisLois TatisLois merged commit 4492f8b into staging Dec 30, 2021
@m1guelpf m1guelpf deleted the fix/buy-modal-listedby branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant