This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Resolve undefined variable for listed by value #636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
item
is not defined in theBuyModal
component and causes the buying flow to break. The value representingitem
is passed in as a prop named token. Naming/Data flow will be an area of improvement when the modals are refactored + types will help.I also left a small comment in
apps/next-react/src/components/TokenGridV5.js
mentioning that the value oftoken={buyModal}
is the same as an item in the items list.How
Update references to item to token
Test Plan
Tested locally by going through a few buy flows
CALL OUT
Eslint should have caught this and when I tested it out, I had inconsistent results 😱 needs to be looked into...