Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Resolve sticky position when a modal is open #640

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

TatisLois
Copy link
Contributor

Why

Latest pending release is blocked by a bug caused by having a modal open on the home page. The header and left/right col's should have position sticky applied. But are not being stuck. After debugging it turns out that the integration for next.js and expo applies various css resets.

We want (I assume) to keep most of them to maintain compatibility with react native web so this PR only changes the value of the offending property.

How

Apply the tailwind class overflow-y-visible to body set the default value of overflow-y

Test Plan

Test on local before push and will test on vercel route

Bug

sticky-bug.mp4

Solution

sticky-solution.mp4

@vercel
Copy link

vercel bot commented Jan 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/BTPcDEStGvmUHFckiPbF1kB3bKFX
✅ Preview: https://showtime-git-fix-sticky-scroll-homepage-showtime.vercel.app

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-640&sdkVersion=44.0.0

Comment ID:

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-640&sdkVersion=44.0.0

Comment ID:

Copy link

@m1guelpf m1guelpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for figuring this out! ❤️

@TatisLois TatisLois merged commit 0e20846 into staging Jan 3, 2022
@m1guelpf m1guelpf deleted the fix/sticky-scroll-homepage branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants