This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Resolve sticky position when a modal is open #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Latest pending release is blocked by a bug caused by having a modal open on the home page. The header and left/right col's should have position sticky applied. But are not being stuck. After debugging it turns out that the integration for next.js and expo applies various css resets.
We want (I assume) to keep most of them to maintain compatibility with react native web so this PR only changes the value of the offending property.
How
Apply the tailwind class overflow-y-visible to
body
set the default value of overflow-yTest Plan
Test on local before push and will test on vercel route
Bug
sticky-bug.mp4
Solution
sticky-solution.mp4