Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Card social buttons #641

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Card social buttons #641

merged 2 commits into from
Jan 4, 2022

Conversation

axeldelafosse
Copy link
Contributor

@axeldelafosse axeldelafosse commented Jan 3, 2022 •
edited
Loading

Why

Implements the Card social buttons component

How

  • Adding the social buttons

Test Plan

  • Check Storybook on web and native
  • Check the apps

@linear
Copy link

linear bot commented Jan 3, 2022

SHOW2-272 Card

  • Media
    • Click to enlarge
  • Buttons
  • Platform
  • Social
  • Title
  • Comment
  • Owner (market)
  • Sub elements
    • Ownership
    • Icon

🟢 card - 📚 UI Library (Figma)

@vercel
Copy link

vercel bot commented Jan 3, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/BAP2aMNMpjASiEqbz3K9VLhGeN6t
✅ Preview: https://showtime-git-feature-show2-272-card-showtime.vercel.app

@github-actions
Copy link

github-actions bot commented Jan 3, 2022 •
edited
Loading

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-641&sdkVersion=44.0.0

Comment ID: 1004247752

@github-actions
Copy link

github-actions bot commented Jan 3, 2022 •
edited
Loading

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-641&sdkVersion=44.0.0

Comment ID: 1004249597

@axeldelafosse axeldelafosse changed the title Card Card social buttons Jan 3, 2022
@axeldelafosse axeldelafosse marked this pull request as ready for review January 3, 2022 19:14
axeldelafosse
axeldelafosse commented Jan 3, 2022
View reviewed changes
packages/design-system/card/social/button.tsx Outdated
Comment on lines 105 to 111
<Pressable
tw={[
"h-8 p-2 flex-row items-center rounded-full dark:bg-gray-900",
isHovered ? backgroundHoverColor : backgroundColor,
isPressed && !isDisabled ? "dark:bg-gray-800" : "",
isDisabled ? "opacity-40 cursor-not-allowed" : "",
]}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf. #642

@intergalacticspacehighway
Copy link
Collaborator

LGTM ✨

gorhom
gorhom reviewed Jan 3, 2022
View reviewed changes
packages/design-system/card/social/button.tsx Outdated
: variant === "boost"
? "bg-green-50"
: "";
const iconActiveColor =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not extract this mapping into a helper function ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

PR Preview - Storybook on Chromatic

✅ Preview: The Storybook preview URL for this Pull Request

✅ Build: The Chromatic build URL for this Pull Request

@axeldelafosse axeldelafosse merged commit a7e289f into staging Jan 4, 2022
@m1guelpf m1guelpf deleted the feature/show2-272-card branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gorhom gorhom gorhom left review comments

@intergalacticspacehighway intergalacticspacehighway intergalacticspacehighway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axeldelafosse @intergalacticspacehighway @gorhom