Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Add AnimatePresence to SelectList on web #647

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

axeldelafosse
Copy link
Contributor

@axeldelafosse axeldelafosse commented Jan 4, 2022

Why

@nandorojo had a look at our design system and noticed that this component is missing AnimatePresence. Thank you Fernando!

How

Added AnimatePresence

Test Plan

Run Storybook on web and use the Select component, you should see the exit animation: https://619f8881c3b4c2003a08edf7-rkmanexmsg.chromatic.com/?path=/story/components-select--regular

@vercel
Copy link

vercel bot commented Jan 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/Bx8yR243uujv2yngMAPRcziDMVnH
✅ Preview: https://showtime-git-add-animate-presence-showtime.vercel.app

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-647&sdkVersion=44.0.0

Comment ID:

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-647&sdkVersion=44.0.0

Comment ID:

Copy link
Collaborator

@intergalacticspacehighway intergalacticspacehighway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks Fernando!

@axeldelafosse axeldelafosse changed the title Add animate presence to select list on web Add AnimatePresence to SelectList on web Jan 4, 2022
@axeldelafosse axeldelafosse merged commit 9483f15 into staging Jan 4, 2022
@m1guelpf m1guelpf deleted the add-animate-presence branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants