This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Update styles and semantics for listed for per feedback #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uested design feedback
TatisLois
requested review from
a user,
axeldelafosse,
fontanierh,
intergalacticspacehighway and
m1guelpf
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/showtime/showtime/5cNfu1umSvctXcDPVapj7u3jhdQi |
PR Preview - StorybookThis pull request preview deployment is now available. ✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-660&sdkVersion=44.0.0 Comment ID: 1006298924 |
PR Preview - AppThis pull request preview deployment is now available. ✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-660&sdkVersion=44.0.0 Comment ID: 1006300516 |
PR Preview - Storybook on Chromatic |
TatisLois
added a commit
that referenced
this pull request
Jan 17, 2022
* upgrade mmkv * Home/Feed (#655) * feed tabs * pinch to zoom * pinch to zoom * pinch to zoom * pinch to zoom * fix: feed ptr * fix: feed images * fix: feed images * wip: feed * wip: feed * wip: feed * wip - feed * wip - feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * wip: feed * upgrade mmkv * use correct app scheme and icon for walletconnect * improve walletconnect implementation * automatically submit when wallet is connected * Adjust gas price by a percentage (#653) * create video component * Feature/show2 290 trending screen (#663) * wip: trending * wip: trending * wip: trending * wip: trending * make api fast again * optimise creator previre * optimise creator preview * optimise creator preview * optimise creator preview * Update to handle long collection names (#662) * Enable Magic on minting & marketplace (#665) * install three.js + upgrade to react 18 + patch packages * add model component * Misc fixes (#666) * spinner fix * spinner fix * add swr * add swr * add swr * initial scroll fix * add accessToken hook (#667) * fix: added `useAccessToken` to access token for web (#669) * feat(SHOW2-225): refactor modal component (#652) * refactor: updated the modal styling for web * fix: fixed tailwind colors import * refactor: updated the modal styling for mobile * chore: reset modal storybook visibility * refactor: removed index.web * fix: fixed the modal body styling on mobile * refactor: updated modal styling for web/ios * fix: modal gestures components on Android Co-authored-by: Axel Delafosse <[email protected]> * list improvements (#671) * list improvements * list improvements * list improvements * list improvements * list improvements * list improvements * list improvements * render model as image for now * mark svg as todo * mark blurhash as todo on android * update logo * add nft title and description components * clean code * Update styles and semantics for listed for per feedback (#660) * disable save changes button when username is not available (#674) * use suspense + add types + add navigation elements context and hook to hide * improve collection component * add send icon * add comments + message box * use constants for scroll and padding height * clean code * chore(magic): add magic flag in useFlags and import them into modals (#675) * Profile screen (#677) * add flipper * add flipper * inti * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * enable double tap * list improvements * list improvements * wip profile * wip profile * profile api * profile wip * profile wip * profile wip * profile wip * profile wip * profile wip * profile wip * wip profile * wip profile * wip profile * wip profile * wip profile * wip profile * profile change route param * add react navigation to storybook RN * add react navigation to storybook RN * add react navigation to storybook RN * add react navigation to storybook RN * add camera * add reanimated handler to pager (#678) * add reanimated handler to pager * add reanimated handler to pager * new tabs * Revert "new tabs" This reverts commit b88ae0b. * upgrade vision-camera * add create modal * clean code * refactor: updated tabs item header width to be dynamic (#681) * update dependencies * upgrade deps and revert yarn.lock changes * use text-13 for tab items * render svg via xml + disabled press on media if in nft modal * fix camera tab bar icon container size * set trending tabs to full width screen * use suspense for profile tabs * clean header dropdown * Show an error when username is too short * set user color scheme * update status bar * fix imports * Feature/show2 309 create (#688) * fieldset * wip create UI * wip create UI * wip create UI * wip create UI * remove animated view from header (#692) * use media component everywhere * use the modal component for the create screen * fix: color mode re-renders * fix: color mode re-renders * fix: color mode re-renders * feat(SHOW2-283): added login with SMS flow and refactor login styling (#672) * fix: updated the button height based on design system * refactor: updated login screen styling * feat: added keyboard handling for iOS & Android * refactor: extracted email field ui into a separate component * feat: added phone number field * refactor: added contact details and remove email and phone number components * feat: added loading view * chore: removed debug console logs * fix: set loading state on phone number submitting * refactor: extract root magic instance * refactor: updated tabs header item indicator positioning * refactor: added a generic input field * refactor: extracted login container and header * refactor: updated login design to follow design system * fix: prevent tab header from setting invalid height * refactor: added text content type to input field * fix: logout customer when app fails to login * fix(unlist): allow an item to be unlisted by the owner when it not the lowest item for sale (#683) * Resolve an issue with next.js caching user profiles to a 404 (#680) (#698) Co-authored-by: Axel Delafosse <[email protected]> * rework explore page for marketplace (#700) * rework explore page for marketplace * fix mobile links * fix feed button tracking events Co-authored-by: Axel Delafosse <[email protected]> Co-authored-by: Nishan <[email protected]> Co-authored-by: Axel Delafosse <[email protected]> Co-authored-by: Miguel Piedrafita <[email protected]> Co-authored-by: Mo Gorhom <[email protected]> Co-authored-by: Henry Fontanier <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this linear issue
299
Why
Feedback from design on copy and UI
How
Spotlightchecks if the item is free or a single edition, removes royalties info and updates it's copyTest Plan
Test locally as the listing owner and as an anon account (see buy output)
Screenshots