Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Media #664

Merged
merged 7 commits into from
Jan 10, 2022
Merged

Media #664

merged 7 commits into from
Jan 10, 2022

Conversation

axeldelafosse
Copy link
Contributor

@axeldelafosse axeldelafosse commented Jan 6, 2022

Why

This PR improves the Media component. It can be used for the feeds and for the View NFT modal. It should support images, videos, SVGs and 3D models.

How

  • Created a Video component
  • Created a Model component
  • Installed three.js with react-three-fiber and expo-gl

Test Plan

Run the app

@linear
Copy link

linear bot commented Jan 6, 2022

SHOW2-289 Media

  • Single

  • Grid

  • Photo

  • Video

  • 3D Model

@vercel
Copy link

vercel bot commented Jan 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/DmWK1mnqhE89dVg1U3kuY53NJcVD
✅ Preview: https://showtime-git-feature-show2-289-media-showtime.vercel.app

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-664&sdkVersion=44.0.0

Comment ID: 1006493982

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-664&sdkVersion=44.0.0

Comment ID: 1006497038

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

PR Preview - Storybook on Chromatic

✅ Preview: The Storybook preview URL for this Pull Request

✅ Build: The Chromatic build URL for this Pull Request

@axeldelafosse
Copy link
Contributor Author

I decided to display the 3D model as an image for now. Marc is going to help us with the ArrayBuffer issues we encountered.

@axeldelafosse axeldelafosse marked this pull request as ready for review January 10, 2022 09:29
@axeldelafosse
Copy link
Contributor Author

axeldelafosse commented Jan 10, 2022

Also I tried displaying the SVGs in a WebView but I really don't like this solution. Can we find a backend-focused solution? Is it possible to save a preview image of the SVG for example? cc @fontanierh

Copy link
Collaborator

@intergalacticspacehighway intergalacticspacehighway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool 🔥. Will replace media with this one in next PRs.

@fontanierh
Copy link
Contributor

Also I tried displaying the SVGs in a WebView but I really don't like this solution. Can we find a backend-focused solution? Is it possible to save a preview image of the SVG for example? cc @fontanierh

I reckon we could go for a backend solution yes. I think there's already a thumbnail, but might be too small.
Will look into it, added a card here

@axeldelafosse axeldelafosse merged commit b8568cf into staging Jan 10, 2022
@m1guelpf m1guelpf deleted the feature/show2-289-media branch January 26, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants