Fix #291: Changed dropdown icon to Icon.Menu for clarity and consistency. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veger
approved these changes
Jan 10, 2025
|
@shpaass mentioned a 'mini hamburger', so let's wait to see if this is 'mini' enough. Or we need to scale it a little or create a smaller icon. But code-wise this PR is good |
|
@Rout222 Thank you for taking care of the technical side! That will help us to get this issue solved.
For the column menus, I think we need to make the icon a bit smaller, so there is at least some hierarchy between them and the main menu on the top left. |
|
Regarding the top-right icon, we probably want some magnifying-glass icon to indicate that it's about the search. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #291 by changing to the
Icon.Menu.Changed in two places: