Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain keywords cannot be included as stream/table attributes #1742

Closed
senthuran16 opened this issue Sep 6, 2021 · 1 comment · Fixed by #1748
Closed

Certain keywords cannot be included as stream/table attributes #1742

senthuran16 opened this issue Sep 6, 2021 · 1 comment · Fixed by #1748

Comments

@senthuran16
Copy link
Member

senthuran16 commented Sep 6, 2021

Description:
The following keywords cannot be included as an attribute in a stream/table definition:

FUNCTION
TRIGGER
OFFSET
SET
AT
IN
AGGREGATION
AGGREGATE
PER

eg: If we consider offset as an attribute, the following stream definition is invalid

define stream SweetProductionStream (name string, amount long, offset string);

However, we allow other keywords (such as LIMIT).

OS, DB, other environment details and versions:
WSO2 SI 1.1.0 and WSO2 SI Tooling 1.1.0

Steps to reproduce:

  1. Deploy the following Siddhi application:
@App:name('SweetTotalApp')

define stream SweetProductionStream (name string, amount long, offset string);
 
@sink(type='log', prefix='Sweet Totals:')
define stream SweetTotalStream(count long);

@info(name='SweetTotalQuery')
from SweetProductionStream#window.timeBatch(1 min)
select count() as count
insert into SweetTotalStream;
  1. It would result in the following error:
[2021-09-03 16:58:18,726] ERROR {org.wso2.carbon.streaming.integrator.core.internal.StreamProcessorDeployer} - org.wso2.carbon.streaming.integrator.core.internal.exception.SiddhiAppConfigurationException: Exception occurred when retrieving Siddhi App Name org.wso2.carbon.streaming.integrator.core.internal.exception.SiddhiAppDeploymentException: org.wso2.carbon.streaming.integrator.core.internal.exception.SiddhiAppConfigurationException: Exception occurred when retrieving Siddhi App Name 
	at org.wso2.carbon.streaming.integrator.core.internal.StreamProcessorDeployer.deploySiddhiQLFile(StreamProcessorDeployer.java:110)
	at org.wso2.carbon.streaming.integrator.core.internal.StreamProcessorDeployer.deploy(StreamProcessorDeployer.java:333)
	at org.wso2.carbon.deployment.engine.internal.DeploymentEngine.lambda$deployArtifacts$0(DeploymentEngine.java:291)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at org.wso2.carbon.deployment.engine.internal.DeploymentEngine.deployArtifacts(DeploymentEngine.java:282)
	at org.wso2.carbon.deployment.engine.internal.RepositoryScanner.sweep(RepositoryScanner.java:112)
	at org.wso2.carbon.deployment.engine.internal.RepositoryScanner.scan(RepositoryScanner.java:68)
	at org.wso2.carbon.deployment.engine.internal.DeploymentEngine.start(DeploymentEngine.java:121)
	at org.wso2.carbon.deployment.engine.internal.DeploymentEngineListenerComponent.onAllRequiredCapabilitiesAvailable(DeploymentEngineListenerComponent.java:216)
	at org.wso2.carbon.kernel.internal.startupresolver.StartupComponentManager.lambda$notifySatisfiableComponents$7(StartupComponentManager.java:266)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at org.wso2.carbon.kernel.internal.startupresolver.StartupComponentManager.notifySatisfiableComponents(StartupComponentManager.java:252)
	at org.wso2.carbon.kernel.internal.startupresolver.StartupOrderResolver$1.run(StartupOrderResolver.java:204)
	at java.util.TimerThread.mainLoop(Timer.java:555)
	at java.util.TimerThread.run(Timer.java:505)
Caused by: org.wso2.carbon.streaming.integrator.core.internal.exception.SiddhiAppConfigurationException: Exception occurred when retrieving Siddhi App Name 
	at org.wso2.carbon.streaming.integrator.core.internal.StreamProcessorService.getSiddhiAppName(StreamProcessorService.java:288)
	at org.wso2.carbon.streaming.integrator.core.internal.StreamProcessorDeployer.deploySiddhiQLFile(StreamProcessorDeployer.java:94)
	... 14 more
Caused by: io.siddhi.query.compiler.exception.SiddhiParserException: Error between @ Line: 4. Position: 0 and @ Line: 4. Position: 63. Syntax error in SiddhiQL, no viable alternative at input 'offset'.
	at io.siddhi.query.compiler.internal.SiddhiErrorListener.syntaxError(SiddhiErrorListener.java:36)
	at org.antlr.v4.runtime.ProxyErrorListener.syntaxError(ProxyErrorListener.java:41)
	at org.antlr.v4.runtime.Parser.notifyErrorListeners(Parser.java:544)
	at org.antlr.v4.runtime.DefaultErrorStrategy.reportNoViableAlternative(DefaultErrorStrategy.java:310)
	at org.antlr.v4.runtime.DefaultErrorStrategy.reportError(DefaultErrorStrategy.java:136)
	at io.siddhi.query.compiler.SiddhiQLParser.name(SiddhiQLParser.java:8522)
	at io.siddhi.query.compiler.SiddhiQLParser.attribute_name(SiddhiQLParser.java:8096)
	at io.siddhi.query.compiler.SiddhiQLParser.definition_stream(SiddhiQLParser.java:647)
	at io.siddhi.query.compiler.SiddhiQLParser.siddhi_app(SiddhiQLParser.java:331)
	at io.siddhi.query.compiler.SiddhiQLParser.parse(SiddhiQLParser.java:178)
	at io.siddhi.query.compiler.SiddhiCompiler.parse(SiddhiCompiler.java:74)
	at org.wso2.carbon.streaming.integrator.core.internal.StreamProcessorService.getSiddhiAppName(StreamProcessorService.java:275)
	... 15 more

@dnwick
Copy link
Contributor

dnwick commented Sep 16, 2021

This is fixed - wso2/carbon-analytics#1959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants