Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store apt key sensible location #2475

Closed
1 task done
KwadroNaut opened this issue Jun 20, 2018 · 2 comments
Closed
1 task done

Store apt key sensible location #2475

KwadroNaut opened this issue Jun 20, 2018 · 2 comments

Comments

@KwadroNaut
Copy link

  • I have searched open and closed issues for duplicates

Bug description

The Linux install instructions refer to the use of apt-key add, while common it's generally a bad idea to mix this key in with others. Best is to make it available separately and mark them acceptable for this repository only.
Current recomendations:

curl -s https://updates.signal.org/desktop/apt/keys.asc | sudo apt-key add -
echo "deb [arch=amd64] https://updates.signal.org/desktop/apt xenial main" | sudo tee -a /etc/apt/sources.list.d/signal-xenial.list
sudo apt update && sudo apt install signal-desktop

Expected something like:

curl -s https://updates.signal.org/desktop/apt/keys.asc | gpg --dearmor | sudo tee /usr/share/keyrings/signal-xenial-pub.gpg >/dev/null
echo "deb [arch=amd64, signed-by=/usr/share/keyrings/signal-xenial-pub.gpg] https://updates.signal.org/desktop/apt xenial main" | sudo tee -a /etc/apt/sources.list.d/signal-xenial.list
sudo apt update && sudo apt install signal-desktop

More background info: https://wiki.debian.org/DebianRepository/UseThirdParty https://lists.gnupg.org/pipermail/gnupg-users/2017-June/058502.html

Platform info

Signal version:
Irrelevant.

Operating System:
Description: Debian GNU/Linux 9.4 (stretch)

@strugee
Copy link
Contributor

strugee commented Aug 13, 2018

@KwadroNaut you shouldn't put things in /usr/share manually; that's reserved for the package manager. Maybe you want to put it into /etc/apt/trusted.gpg.d (with apt-key add --keyring), but I don't know if the signed-by will still work to properly restrict the repositories the key can sign.

@KwadroNaut
Copy link
Author

@strugee see linked Debian wikipage:

… to a location only writable by root, which SHOULD be /usr/share/keyrings. The key MUST NOT be placed in /etc/apt/trusted.gpg.d or loaded by apt-key add.

/usr/share/ isn't reserved for the package manager, it's just architecture-independent (shared) data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants