Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC to delay before switching back to recovered beacon node #3002

Closed
paulhauner opened this issue Feb 7, 2022 · 2 comments
Closed

VC to delay before switching back to recovered beacon node #3002

paulhauner opened this issue Feb 7, 2022 · 2 comments
Labels
enhancement New feature or request val-client Relates to the validator client binary

Comments

@paulhauner
Copy link
Member

Description

As per this thread, it seems to make sense to delay switching back to a BN after it comes back online (e.g., if primary was offline but came back online). This allows the BN to get itself in order and acts as a bit of a "debounce".

I propose a 2-3 epoch delay.

@lfinbob
Copy link

lfinbob commented Aug 27, 2022

I had a disappointing fallback experience today where this would have helped:
My lighthouse validator is connected to 2 different lighthouse beacon nodes.
The primary one is on the same machine, the other is remote.
Then, on the primary machine I changed my beacon node's p2p port and restarted it.
It had 0 (or low) peers for ~15 minutes, because I was slow to update my firewall rules.
During that time my validator happily sent attestations to the low-peer beacon node instead of the 100-peer beacon node and I missed 3 attestations in a row.

@macladson
Copy link
Member

Since the merging of #4393, we now have more sophisticated fallback behaviour. While this behaviour does not include a debounce, it should not switch back to a disconnected node until it is synced close to the head (default is within 8 slots) which should help this particular issue. So I will close this for now, and if fallback issues continue to be widespread, new issues should be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request val-client Relates to the validator client binary
Projects
None yet
Development

No branches or pull requests

4 participants