No version info in homebrew package

[michaelsproul]

The homebrew package builds without the full git sources, which leads to its version showing as Lighthouse unknown. We should work out a way to inject the version from homebrew, or switch homebrew to use git (I suspect they won't want to do this due to the increased size)

[ackintosh]

How about using env!("CARGO_PKG_VERSION") as the fallback?

I will file a PR if it looks good to you. 😃

[realbigsean]

I think this would result in us displaying the version of the lighthouse_version crate, which is 0.1.0 right now.. but maybe we should actually track this version with our lighthouse release version? Would just need to add it to the change_version.sh script

[ackintosh]

I noticed that the change_version.sh script does the replacing below:

lighthouse/scripts/change_version.sh

Line 34 in 46a0606

sed -i -e "s/$FROM/$TO/g" $VERSION_CRATE

the VERSION_CRATE variable points lighthouse_version/src/lib.rs:

lighthouse/scripts/change_version.sh

Line 17 in 46a0606

VERSION_CRATE="../common/lighthouse_version/src/lib.rs"

---

Therefore we don't need to use env!("CARGO_PKG_VERSION"), just hard code the version number. 💡

pub const VERSION: &str = git_version!(
    args = [
        "--always",
        "--dirty=+",
        "--abbrev=7",
        // NOTE: using --match instead of --exclude for compatibility with old Git
        "--match=thiswillnevermatchlol"
    ],
    prefix = "Lighthouse/v2.2.1-",
-   fallback = "unknown"
+   fallback = "Lighthouse/v2.2.1" // Note: unlike `prefix`, the trailing hyphen was striped.
);