Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Criterion #5819

Closed
eserilev opened this issue May 21, 2024 · 3 comments
Closed

Update Criterion #5819

eserilev opened this issue May 21, 2024 · 3 comments
Assignees
@michaelsproul
Labels
dependencies Pull requests that update a dependency file

Comments

@eserilev
Copy link
Collaborator

Description

Our current version of criterion depends on clap 2.x, the new criterion version (0.5) depends on clap 4.x. In #5273 were upgrading clap to 4.x. We should upgrade Criterion to 0.5 so we can completely remove the clap 2.x dependency from our codebase
@eserilev eserilev added the dependencies Pull requests that update a dependency file label May 21, 2024
@michaelsproul
Copy link
Member

I've started on this

@michaelsproul michaelsproul self-assigned this Jun 4, 2024
@michaelsproul michaelsproul mentioned this issue Jun 4, 2024
Merged
@michaelsproul
Copy link
Member

PR here:

@eserilev
Copy link
Collaborator Author

eserilev commented Jun 5, 2024

Closed in #5886

@eserilev eserilev closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsproul michaelsproul

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @eserilev