Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC legacy server does not return correct error statuses #525

Closed
haydentherapper opened this issue Apr 15, 2022 · 1 comment · Fixed by #526
Closed

gRPC legacy server does not return correct error statuses #525

haydentherapper opened this issue Apr 15, 2022 · 1 comment · Fixed by #526
Labels
bug Something isn't working

Comments

@haydentherapper
Copy link
Contributor

Description

When the gRPC server returns an error to the legacy server, the errors are wrapped and returned, such as here

This results in the error status always being a 500, with the JSON error response code being '2' for unknown error. For example, {"code":2,"message":"legacy handler: rpc error: code = InvalidArgument desc = The public key supplied in the request could not be parsed","details":[]}

Looking into this now...

cc @bobcallaway

fyi @cpanato @dlorenc, probably shouldn't cut a new release til we resolve this.
@haydentherapper haydentherapper added the bug Something isn't working label Apr 15, 2022
@haydentherapper
Copy link
Contributor Author

Ah easy fix! Just needed to remove the wrapped error.

@haydentherapper haydentherapper mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix null pointer crash and incorrect error statuses haydentherapper/fulcio
1 participant
@haydentherapper