-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SCT verification #22
Comments
I've had a look for some potential libraries that include functionality to verify signed certificate timestamps. Here are the two main candidates:
At the moment, I'm leaning towards just hand-rolling the SCT verification ourselves. There doesn't seem to be an obvious choice and from what I can see, it shouldn't be all that difficult to implement ourselves. Thoughts @di and @woodruffw? |
It looks like google/certificate-transparency is not really maintained anymore. Additionally, it seems to be mostly implemented in C++, which might be a dealbreaker for us here. There is also an example at https://github.com/pierky/sct-verify/blob/master/sct-verify.py that might be helpful for us here, which calls out to |
Ok, there seems to be some issues preventing us from using The way it should really work and how I think at this point I'm going to just check the public key into our repo and leave the TUF part for further down the track. |
I think this is fine for now, but let's make sure we create an issue to capture getting the root via TUF for the future. |
Here's a draft branch of the Java client's implementation of SCT verification, for reference: https://github.com/sigstore/sigstore-java/compare/add-sct-verification |
Captured in #25. |
Here's the finished implementation for the Java client: sigstore/sigstore-java#1 |
This doesn't seem to exist in pyca/cryptography. We should check whether there's another library that includes this functionality. If not, we might need to hand-roll it ourselves.
The text was updated successfully, but these errors were encountered: