Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup i18n translation files #1

Open
ricardocasares opened this issue Oct 18, 2018 · 13 comments
Open

Setup i18n translation files #1

ricardocasares opened this issue Oct 18, 2018 · 13 comments
Labels

Comments

@ricardocasares
Copy link
Member

Let's try to setup i18n during Hacktoberfest 2018! 🎉

@juansaintclair
Copy link

juansaintclair commented Oct 18, 2018

Want me to translate it to PT-BR?

@ricardocasares
Copy link
Member Author

@juansaintclair that'd be great! 🙌🏻
@fatiherikli is there anything else you would like to add here before @juansaintclair starts on this?

@victorhck
Copy link

I can translate to Spanish...

@ricardocasares
Copy link
Member Author

@victorhck that's awesome!

There are a few i18n libraries out there, but let's wait for @fatiherikli's input on what the approach will be on that side, but we can already start with some json files.

Let's take this turkish translation as a base for the keys we'll need and let's follow i18next with next.js example as shown here, using same directory structure: static/locales/[locale]

Later, if the approach changes, we can easily manipulate json to other formats.

@juansaintclair @victorhck does this sound OK for you?

@victorhck
Copy link

sorry, can't translate from Turkish... is that a problem?

@ricardocasares
Copy link
Member Author

Me neither :D, just use the keys from the TR translation for reference, in that same file there's an incomplete english translation, we can reuse whatever we can from there. Keys are in english by the way!

Having these files in place will be already a good starting point so anyone else can jump in and help :)

@ricardocasares ricardocasares added the good first issue Good for newcomers label Oct 18, 2018
@ricardocasares ricardocasares changed the title Setup i18n Setup i18n translation files Oct 18, 2018
@diamentowybazant
Copy link

diamentowybazant commented Oct 18, 2018

@ricardocasares, check this out! Maybe locale should be two-letter ISO 639-1 language code? See list here.

@ricardocasares
Copy link
Member Author

@diamentowybazant fantastyczny!

@ricardocasares, check this out! Maybe locale should be two-letter ISO 639-1 language code? See list here.

Yes! Let's use two letter codes for languages.

@juansaintclair @victorhck we need to agree on the keys we'll use as they must be the same in all translation files, check out the keys @diamentowybazant used and let's use those keys as reference since he already put the PR together.

@juansaintclair
Copy link

There are no 'Brazilian Portuguese', may I put just 'pt'?

@ricardocasares
Copy link
Member Author

hmm @juansaintclair, maybe it's better to add pt-br, I'm not really sure what's the difference, for example I'm from Argentina so we have es-ar, but being completely honest, I would just add es as the differences are really minimal. Not sure that's the case between pt and pt-br, I'd rather let you take that decision.

In any case, obrigado 🇧🇷!, thanks for all this work, it's really exciting to see so many people collaborating from different parts of the world.

@juansaintclair
Copy link

In that case, I think it's better let 'PT-BR', there are lots of particularities between Portugal's Portuguese and Brazil's Portuguese.

@capitanfindusfi
Copy link

capitanfindusfi commented Oct 19, 2018

I can try translating it into Italian it

should be fixed with pull request #11

@henriklagergren
Copy link

Added swedish translation (#12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants