-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #11
Comments
This should be done at the end of the cleanup stage. Reason: Some of the tests have been turned off because they take too long to run. If we upgrade now (before adjusting the tests) then we may break the tests unknowingly. |
Actually we still need to run the cargo command to upgrade the dependencies |
curve25519_dalek_ng VS curve25519_dalekThe former has the following text:
Relevant: dalek-cryptography/curve25519-dalek#345 The former has not been updated in 2 years, but the latter was updated last week. Going to rather use the original repo. |
Turns out you cannot switch from curve25519_dalek_ng to curve25519_dalek without breaking the bulletproofs dependency, because it uses curve25519_dalek_ng |
I raised a question on the bulletproofs repo: zkcrypto/bulletproofs#15 |
Just waiting on v5 to be published zkcrypto/bulletproofs#22 |
The text was updated successfully, but these errors were encountered: