Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish implementing WithinRangeFilter class #11017

Open
sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Open

Finish implementing WithinRangeFilter class #11017

sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023 •
edited by GuySartorelli
Loading

Description

WithinRangeFilter is marked as incomplete and requires test cases. It currently has no syntax for use in DataList::filter() and is very hard to add in any other context. We should finish the implementation of this filter, or consider removing it.

See:

silverstripe-framework/src/ORM/Filters/WithinRangeFilter.php

Line 10 in cf78a9d

* @todo add to tests

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: Refactoring WithinRangeFilter class Finish implementing WithinRangeFilter class Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sabina-talipova