Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: DataObject::setFieldValue improvememnts #11027

Closed
sabina-talipova opened this issue Oct 18, 2023 · 2 comments
Closed

TODO: DataObject::setFieldValue improvememnts #11027

sabina-talipova opened this issue Oct 18, 2023 · 2 comments

Comments

@sabina-talipova
Copy link
Contributor

Description

If a field is not existing or has strictly changed:

  • Add check for php-level defaults which are not set in the db
  • Add check for hidden input-fields (readonly) which are not set in the db

See:

// TODO Add check for php-level defaults which are not set in the db
// TODO Add check for hidden input-fields (readonly) which are not set in the db

@GuySartorelli
Copy link
Member

@sabina-talipova Do you know what is meant by "php-level defaults which are not set in the db"? Or "hidden input-fields (readonly) which are not set in the db"?
I'm not sure what either of those are in this context.

@sabina-talipova
Copy link
Contributor Author

Probably we can close this ticket, since It's existing since 2016 and probably it was there even early. And I think it's not actual any more.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants