Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have indicator to distinguish the gif and other normal pictuIres #24

Closed
ooker777 opened this issue Apr 1, 2015 · 9 comments
Closed

Comments

@ooker777
Copy link

ooker777 commented Apr 1, 2015

I think this will be useful. Maybe a play button, or this is a gif, or just gif. What do you think?

@simonlindholm
Copy link
Owner

The request has come up in the past and it would be certainly useful, but it turns out be hard to implement, especially when you don't want to affect page load performance. Closing as dup of #16, see the discussion there.

@LL25255252
Copy link

@ooker777 , this is not a perfect solution but you can try my userstyle:
https://userstyles.org/styles/112111/global-add-dashed-border-to-gif-images

@ooker777
Copy link
Author

ooker777 commented Apr 2, 2015

@LL25255252 is your userscript a fork of this addon? What is the relationship between two?

@LL25255252
Copy link

No it's not a fork. It's not a userscript, it's a userstyle for the Stylish addon based on @simonlindholm idea - see also #10 (comment)
The style indicates (by adding a dashed border) which images in the page are animated. Useful especially if the addon's "Pause Gif's by default" is enabled and you can't tell if the image is a regular image or a gif.
Try it. You can always easily uninstall it.

@Benguin
Copy link

Benguin commented Apr 7, 2015

As an alternative that's probably easier, I'd accept the option of having an icon on the toolbar that shows the number of paused gifs.

@simonlindholm
Copy link
Owner

That sounds just as hard to implement (except UI-wise, maybe). The reason for the difficulty is that the addon doesn't get notified about the fact that there exists animated gifs.

@Benguin
Copy link

Benguin commented Apr 7, 2015

Ah, dang. You can't run a script once the page is finished loading to perform a count? How do extensions like videodownloadhelper do things?

@simonlindholm
Copy link
Owner

I can, and will have to if I want to add this feature in some form, it just makes me sad to have to slow down page loading for every page ever, just to do that... There's additional complications, too, about images appearing dynamically (not that uncommon), and perhaps the APIs not working before images are displayed for the first time, but I haven't really looked into that.

(Pretty sure Video Downloadhelper does that, possibly with a whitelist. But I haven't looked, so I don't know details.)

@simonlindholm
Copy link
Owner

I managed to figure out how to do this. See #16, and the link in the last comment to an XPI. (Feedback appreciated. I'll make an AMO release soon, even if review queues may prolong that somewhat.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants