Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior with direct links #39

Closed
ghost opened this issue Apr 4, 2016 · 5 comments
Closed

Behavior with direct links #39

ghost opened this issue Apr 4, 2016 · 5 comments

Comments

@ghost
Copy link

ghost commented Apr 4, 2016

Some people might prefer autoplaying files when accessing direct links. Would help a lot with "image zoom" extensions, currently I have to always visit the site and manually start playing.

@ghost
Copy link
Author

ghost commented Apr 20, 2016

@simonlindholm Do you get notified of new issues? Did I explain the issue poorly?

@simonlindholm
Copy link
Owner

I do, I just haven't had time to do anything with this extension lately.

It sounds like a valid request, even if I'm not sure know exactly to detect all the cases where autoplay would be wanted... For instance it's unclear how to distinguish images from the page from images overlaid by Thumbnail Zoom Plus. (Maybe it could be nice to just animate all dynamically added images according to some definition of that?)

When you say "direct links", I think of visiting .gif files directly, which could certainly be detected. I opened #6 for that a long time ago, but never got around to adding it because I felt that "animate on hover" was good enough and better in some respects.

@ghost
Copy link
Author

ghost commented Apr 21, 2016

Support for direct links would help immensely, majority of videos and GIFs posted to websites like Reddit are direct links.
I enabled "auto-play on hover" setting, videos don't play when fetched with Mouseover Popup Image Viewer. They do when I disable Toggle animated GIFs extension.

@simonlindholm
Copy link
Owner

Yeah, "auto-play on hover" doesn't help with e.g. Mouseover Popup Image Viewer, nor would #6. That's because the image is not opened "directly" in any technical sense; rather, the addon sees a direct link and adds an element to the page which contains the image. This is mostly indistinguishable from if the page itself had included the image... From a less technical perspective the request makes more sense.

@ghost
Copy link
Author

ghost commented Sep 2, 2017

I had media.autoplay.enabled set to false, this caused the majority of the issues (most notably, being unable to play videos). Because GIF autoplay can be toggled with keyboard shortcut I consider this request as insignificant and will close this issue.

@ghost ghost closed this as completed Sep 2, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant