-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es5 bundle not working on IE11 #210
Comments
Okay, apparently It worked in the past with IE but I really don't want to change anything to make it work in such a browser (I don't even have access to IE11 anymore...). I've added a note to the README that IE is not (officially) supported. I'm sorry that poly-filling does not work in your case, I've added the parameter-transform plugin to the ES5 build chain, you can try out the master-version of pickr.es5.min.js :) |
Hey @simonwep thank you for your fast answer. I can open a PR next week to fix this, obviously without rewriting your code but just by bundling specific babel plugins to the es5 and test on old browsers. |
Hi @Clebiez, the
A PR is welcome :) |
const var that I see in the bundled es5 file is effectively in for loop
|
Would really like to see this land, we're looking for a drop-in colour picker for IE11 only. |
Sorry for the delay. After some tests on ie11 on the master branche, it seems to be fixed. The es5 bundle works well. Thank you for this fix ! |
This has been resolved. |
Hey @simonwep thanks for maintaining this package !
What is the current behavior?
For the 1.6.0 release, es5 bundle not working on old browser.
Using core-js w/ babel-preset-env not fix the problem.
Please provide the steps to reproduce and create a [JSFiddle]
Open https://jsfiddle.net/Simonwep/qx2Lod6r/ or https://simonwep.github.io/pickr/ with an old browser like IE11.
You will see in the console an error.
By the debugger it appears the following line is not understood by the browser :
SCRIPT10006: Expected )
On the line 2 of utils.js
function eventListener(method, elements, events, fn, options = {})
What is the expected behavior?
To fix this issue, I think we have to add the following babel plugin into the transpilation flow : babel-plugin-transform-parameters
To allow spread parameters and default value.
There’s also no way to polyfill it by using es6 bundle.
Your environment:
The text was updated successfully, but these errors were encountered: