Add doesNotIncludeText() assertion
#36
Conversation
lib/assertions.js
Outdated
|
|
||
| let result = element.textContent.indexOf(text) === -1; | ||
| let actual = element.textContent; | ||
| let expected = text; |
There was a problem hiding this comment.
expected = text does not make sense in this case, right?
There was a problem hiding this comment.
Good catch! Would you prefer the name unexpected or something else?
There was a problem hiding this comment.
maybe something like `does not include "${text}"`?
There was a problem hiding this comment.
I can certainly update the phrasing of the message to does not include "${text}", my question is actually regarding what is passed into this.pushResult at the end of this function. Would it be fine to say this.pushResult({ results, actual, unexpected, message });?
There was a problem hiding this comment.
no, because the pushResult method explicitly requires an expected attribute (see api.qunitjs.com/assert/pushResult)
There was a problem hiding this comment.
That's what I figured. this.pushResult({ result, actual, expected: unexpected, message}); would work but seems a little ironic to "expect the unexpected".
|
@Turbo87 Is there anything else that's needed for this to be merged? |
|
@Zureka my initial concern at #36 (comment) is still valid. QUnit will show something as "expected" that was actually not expected. |
lib/assertions.js
Outdated
| } | ||
|
|
||
| if (!message) { | ||
| message = `Expected element ${this.targetDescription} to not include text "${text}"`; |
There was a problem hiding this comment.
I think we can message = expected here like in a few of the other assertions
lib/assertions.js
Outdated
| let expected = `Element ${this.targetDescription} does not include text "${text}"`; | ||
| let actual = expected; | ||
|
|
||
| if(!result) { |
There was a problem hiding this comment.
there is a space missing here after the if
Turbo87
changed the title
doesNotIncludeText() assertion
|
Thanks @Zureka! |
There appears to be a pattern of having a positive and a negative assertion for any given property/attribute. E.g.
isFocusedandisNotFocused,hasAttributeanddoesNotHaveAttribute, andhasClassanddoesNotHaveClass.With that being said, it appears that there doesn't appear to be a corresponding inverse for the
includesTextassertion. Until now!