We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I left a comment on #158 but I thought I would open an issue proposing a new interface for specifying multiple formatters:
SimpleCov.formatters = [ SimpleCov::Formatter::HTMLFormatter, SimpleCov::Formatter::CSVFormatter, ]
This is the current interface:
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ SimpleCov::Formatter::HTMLFormatter, SimpleCov::Formatter::CSVFormatter, ]
I think my proposal is better than the current interface because (conventionally) the [] method is used to fetch a value, not to set a value.
[]
This proposal would not require breaking the current interface SimpleCov.formatter because the new method is named SimpleCov.formatters (with an “s”).
SimpleCov.formatter
SimpleCov.formatters
The text was updated successfully, but these errors were encountered:
👍. Square brackets on constants doing things other than getting values are almost always a smell.
Sorry, something went wrong.
Sounds good to me. Would you mind submitting a PR?
Submitted.
73dd88e
No branches or pull requests
I left a comment on #158 but I thought I would open an issue proposing a new interface for specifying multiple formatters:
This is the current interface:
I think my proposal is better than the current interface because (conventionally) the
[]
method is used to fetch a value, not to set a value.This proposal would not require breaking the current interface
SimpleCov.formatter
because the new method is namedSimpleCov.formatters
(with an “s”).The text was updated successfully, but these errors were encountered: