Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleCov doesn't specify a json dependency #72

Closed
sferik opened this issue Sep 12, 2011 · 0 comments
Closed

SimpleCov doesn't specify a json dependency #72

sferik opened this issue Sep 12, 2011 · 0 comments

Comments

@sferik
Copy link
Collaborator

sferik commented Sep 12, 2011

SimpleCov switch from YAML to JSON in 94019a8, however a JSON dependency was never added to the gemspec.

This is fine in Ruby 1.9, where JSON is included in the standard library, but breaks on earlier Ruby versions.

I would advocate for specifying a MultiJSON dependency instead of a particular JSON library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sferik @colszowka