Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.1 support and xmlseclibs #97

Closed
chris1312 opened this issue Jun 5, 2017 · 2 comments
Closed

PHP 7.1 support and xmlseclibs #97

chris1312 opened this issue Jun 5, 2017 · 2 comments

Comments

@chris1312
Copy link
Contributor

simplesamlphp/saml2 depends on robrichards/xmlseclibs and it is using mcrypt_* functions. Therefore, using this library it results into deprecated errors.

Why using Mcrypt is wrong? Read here https://paragonie.com/blog/2015/05/if-you-re-typing-word-mcrypt-into-your-code-you-re-doing-it-wrong

Has anybody tested SAML2 with robrichards/xmlseclibs 3.0.0+?
@chris1312 chris1312 mentioned this issue Jun 5, 2017
Merged
@thijskh
Copy link
Member

thijskh commented Jun 16, 2017 •
edited
Loading

Yes, I've done some testing with simpleSAMLphp and OpenConext-engineblock and their core functionality remains working, also their testsuites pass with this upgrade. We need to keep it at "2.0 or 3.0" as saml2 currently still supports PHP < 5.6.

@thijskh thijskh closed this as completed Jun 16, 2017
@chris1312
Copy link
Contributor Author

That's nice to hear. Thanks for the update!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thijskh @chris1312