Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack command doesn't make any changes #521

Open
ArtemSmaznov opened this issue Nov 1, 2024 · 10 comments
Open

Stack command doesn't make any changes #521

ArtemSmaznov opened this issue Nov 1, 2024 · 10 comments

Comments

@ArtemSmaznov
Copy link

I have recently switched to immich and installed immich-go to try and stack my photos. The stack command correctly identified files that should be stacked, but does not change anything on the server. After I run the command and refresh the immich timeline page in my browser, I see the mentioned photos remain unstacked. I've compared the file names just to be sure.

Not sure if there has been a regression to this command or if some setup is needed on my server side.

Immich server: v1.118.2 (docker)
immich-go: 1:0.22.1-1 (pacman)

➜ immich-go -debug -log-level DEBUG stack -date=2024-07-09 -yes
immich-go  dev, commit none, built at unknown
. _ _  _ _ . _|_     _  _
|| | || | ||(_| | ─ (_|(_)
               v dev _)

Get server's assets...
Stack following images taken on 2024-07-09 17:15:17.765 -0400 EDT
  PXL_20240709_211517662.RAW-01.COVER.jpg
  PXL_20240709_211517662.RAW-02.ORIGINAL.dng
Stack following images taken on 2024-07-09 17:15:27.314 -0400 EDT
  PXL_20240709_211527223.RAW-01.MP.COVER.jpg
  PXL_20240709_211527223.RAW-02.ORIGINAL.dng
Check the log file:  /home/artem/.cache/immich-go/immich-go_2024-10-31_20-23-50.log
➜ cat /home/artem/.cache/immich-go/immich-go_2024-10-31_20-23-50.log
 INFO | Connection to the server http://server:2283 | time="2024-10-31T08:23.50 EDT"
 INFO | Server status: OK | time="2024-10-31T08:23.50 EDT"
 INFO | Connected, user: ***** | time="2024-10-31T08:23.50 EDT"
 INFO |  4 received, 2 stack(s) possible
 | time="2024-10-31T08:23.55 EDT"
@simulot
Copy link
Owner

simulot commented Nov 1, 2024

Immich-go stack command is ineffective since an update of immich API.

I'm working on a new and better version more possibilities:

  • --manage-burst=BurstFlag Manage burst photos. Possible values are:

    • StackKeepRaw Discard JPEG files, and stack the RAW files (default)
    • StackKeepJPEG Discard RAW files, and stack the JPEG files
    • Stack Stack all photos, RAW and JPEG photos are imported in the same stack
  • --manage-heic-jpeg=HeicJpgFlag Manage coupled HEIC and JPEG files. Possible values:

    • KeepHeic Keep only the HEIC files (default)
    • KeepJPG Keep only the JPEG files
    • StackCoverHeic Stack both, the HEIC file is the cover
    • StackCoverJPG Stack both, the JPEG file is the cover
  • --manage-raw-jpeg=RawJPGFlag Manage coupled RAW and JPEG files. Possible values:

    • KeepRaw Keep only the RAW files (default)
    • KeepJPG Keep only the JPEG files
    • StackCoverRaw Stack both, the RAW file is the cover
    • StackCoverJPG Stack both, the JPEG file is the cover

It's implemented for upload in the next release.
I'll work on the stack command soon.

@simulot
Copy link
Owner

simulot commented Nov 1, 2024

You can check the this release: https://github.com/simulot/immich-go/releases/tag/0.23.0-alpha3

@ArtemSmaznov
Copy link
Author

That was fast.

Thanks, will check it out on the weekend.

@ArtemSmaznov
Copy link
Author

That release doesn't have the stack command yet, right?

@simulot
Copy link
Owner

simulot commented Nov 11, 2024

Correct, this is for upload.
I'll re-implement the stack command soon.

@archerne
Copy link

Any update on when the stack command will come back? My library is getting very messy with all of the photos that need stacked. Thanks!

@simulot
Copy link
Owner

simulot commented Dec 12, 2024

I expect to work on it this weekend

@tannermeade
Copy link

tannermeade commented Dec 16, 2024

I expect to work on it this weekend

Just want to say I really appreciate your work on this tool. Looks like you might not have gotten to this, but I noticed you've added support for epson fast foto in the pre-releases which is actually what I'm trying to upload stacked photos from. Wasn't even expecting that to be there since it isn't in the github docs yet. Thanks!!! Stacking seems to be working for uploading fast foto (was having issues with just regular upload stacking but it might have been user error).

@simulot
Copy link
Owner

simulot commented Dec 17, 2024

Thank you... The doc is here: https://github.com/simulot/immich-go/tree/next

I'm working (whenever possible) on the stack command. This reveals new problems that worth to be solved too

@simulot
Copy link
Owner

simulot commented Dec 30, 2024

I have released a pre-version with the command stack last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants