question[TypeScript] How should AggregateError be imported as type when using TypeScript without esModuleInterop option

[oscard0m]

When trying to use AggregateError as type in a Typescript project the following issue happens:

Conditions

• To not use esModuleInterop in tsconfig.json

Tried alternatives

(this would not fit the purpose of getting the type)

---

(it implies enabling moduleInterop flag)

---

Question

Considering the way this library is exposing AggregateError, Is there a way to import AggregateError in a ESModule way as Typescript type (so, no const AggreagateError = require('aggregate-error') and without enabling esModuleInterop option?

Details

You can find more details in:

• https://github.com/octokit/webhooks.js/pull/248/files
• [TypeScript] v7.11.2 has a hard requirement on specific TS configs octokit/webhooks.js#245

[sindresorhus]

This is not the place to ask for general TypeScript support.

[sindresorhus]

Considering the way this library is exposing AggregateError, Is there a way to import AggregateError in a ESModule way as Typescript type (so, no const AggreagateError = require('aggregate-error') and without enabling esModuleInterop option?

I don't think that's possible, no. That is indeed a weird limitation though. I would have expected import type AggreagateError = require('aggregate-error') to work. I would bring this up with the TS team.

[oscard0m]

Considering the way this library is exposing AggregateError, Is there a way to import AggregateError in a ESModule way as Typescript type (so, no const AggreagateError = require('aggregate-error') and without enabling esModuleInterop option?

I don't think that's possible, no. That is indeed a weird limitation though. I would have expected import type AggreagateError = require('aggregate-error') to work. I would bring this up with the TS team.

You are totally right. Sorry for "spamming" issues here. I will address this question to the proper TypeScript channel.

Thanks for your attention and support ❤️

[gr2m]

@sindresorhus the current CommonJS-style export makes aggregate-error hard to consume for ES Module-style libraries such as all the @octokit/* modules. Every consumer of e.g. @octokit/webhooks will have to add skipLibCheck: true to their TSConfig settings, there is nothing on our side that we can do.

A workaround was kindly suggested by @smockle via https://github.com/smockle/aggregate-error-test/: but it requires us to override aggregate-error's type definitions, which puts the burden on us to keep it up-to-date with the implementation.

I understand the change was done here: #9 which I think references sindresorhus/p-cancelable#19, but I don't see the reason why you decided to make that change? Is there a discussion somewhere that I can learn more about your reasoning?

[gr2m]

Update: I've found sindresorhus/memoize#31 (comment) (thanks @smockle)