Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors no longer thrown #107

Closed
Francisc opened this issue Jul 10, 2014 · 9 comments
Closed

Errors no longer thrown #107

Francisc opened this issue Jul 10, 2014 · 9 comments

Comments

@Francisc
Copy link

Hello,

I just updated to latest version and noticed that errors are no longer thrown.
For example, if I assign a variable name that does not exist, the task no longer beeps.

What's up?

@sindresorhus
Copy link
Owner

Works for me:

Running "sass:compile" (sass) task
Warning: /Users/sindresorhus/dev/grunt-sass/test/fixtures/test.scss:7: error: unbound variable $green
 Use --force to continue.

Aborted due to warnings.

What output are you getting?

@Francisc
Copy link
Author

Hey. Hm, it shows as OK but doesn't actually compile.
So the CSS file from the last compilation is kept.

Running "watch" task
Waiting...
>> File "sass\components\_tables.scss" changed.
Running "sass:watcher" (sass) task
Completed in 0.588s at Thu Jul 10 2014 16:49:50 GMT+0300 (GTB Daylight Time) - Waiting...

@Francisc Francisc reopened this Jul 10, 2014
@Francisc
Copy link
Author

Actually, here's just the grunt-sass task running:

With errors:

Running "sass:build" (sass) task

Without errors:

Running "sass:watcher" (sass) task
File css/style.css created.
File css/style.css.map created.

Done, without errors.

Seems to fail silently?

@Francisc
Copy link
Author

Some background:
Windows 7x64 (=Windows 448?)
Node v0.10.26
grunt-cli v0.1.13
grunt v0.4.5
grunt-sass 0.14.0
Call of Duty Ghosts 3.13.123

@sindresorhus
Copy link
Owner

Then that's a node-sass issue. I just pass the errors along.

https://github.com/andrew/node-sass

@Francisc
Copy link
Author

Hm, OK. Thank you.

@Francisc
Copy link
Author

Here's the issue: sass/node-sass#361

If you want source maps, you lose error reporting with the latest version.

Thanks for pointing me in the right direction.

@stevenbriscoeca
Copy link

Thanks, I had the same problem

@aminnaggar-fuzzy
Copy link

Thanks had the same issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants