New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promisify the code #59

Closed

sindresorhus opened this issue Jan 25, 2017 · 0 comments · Fixed by #62

Labels

Owner

sindresorhus commented Jan 25, 2017

Many places use callback. Using promises would make the code more readable. Should use pify.

Mostly thinking in these places:

gulp-changed/index.js

Line 27 in b2aa51f

fs.stat(targetPath, (err, targetStat) => {
gulp-changed/index.js

Line 40 in b2aa51f

fs.readFile(targetPath, (err, targetData) => {

Pull request welcome :)

The text was updated successfully, but these errors were encountered:

sindresorhus added the help wanted label

adamkiss mentioned this issue

Promisify fs methods #62

Merged

sindresorhus closed this as completed in #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment