diff --git a/tap_google_ads/discover.py b/tap_google_ads/discover.py index 13c8861..7e755be 100644 --- a/tap_google_ads/discover.py +++ b/tap_google_ads/discover.py @@ -9,7 +9,7 @@ LOGGER = singer.get_logger() -REPORTS = [ +STREAMS = [ "accessible_bidding_strategy", "ad_group", "ad_group_ad", @@ -176,12 +176,12 @@ def create_resource_schema(config): updated_segments = get_segments(resource_schema, resource) resource["segments"] = updated_segments - for report in REPORTS: - report_object = resource_schema[report] + for stream in STREAMS: + stream_object = resource_schema[stream] fields = {} - attributes = report_object["attributes"] - metrics = report_object["metrics"] - segments = report_object["segments"] + attributes = stream_object["attributes"] + metrics = stream_object["metrics"] + segments = stream_object["segments"] for field in attributes + metrics + segments: field_schema = dict(resource_schema[field]) @@ -224,7 +224,7 @@ def create_resource_schema(config): ): field["incompatible_fields"].append(compared_field) - report_object["fields"] = fields + stream_object["fields"] = fields return resource_schema diff --git a/tap_google_ads/streams.py b/tap_google_ads/streams.py index 587958f..1e4047d 100644 --- a/tap_google_ads/streams.py +++ b/tap_google_ads/streams.py @@ -205,14 +205,8 @@ def extract_field_information(self, resource_schema): self.behavior[field_name] = field["field_details"]["category"] - self.add_extra_fields(resource_schema) self.field_exclusions = {k: list(v) for k, v in self.field_exclusions.items()} - def add_extra_fields(self, resource_schema): - """This function should add fields to `field_exclusions`, `schema`, and - `behavior` that are not covered by Google's resource_schema - """ - def create_full_schema(self, resource_schema): google_ads_name = self.google_ads_resource_names[0]