Newline character ("\n") takes a lot of space.

[ArjanAswal]

The newline character takes a lot of space and fills the entire screen pretty quickly.
In my opinion it should take as much space as the normal line in a paragraph does.
Right now it is taking twice as much.

[singerdmx]

The code should be in default_styles, I suppose

[singerdmx]

Yeah, I agree. Are u able to find the fix?

[ArjanAswal]

DefaultTextBlockStyle( this.style, this.verticalSpacing, this.lineSpacing, this.decoration);

@singerdmx Is it this parameter?

[singerdmx]

Possible. Just try changing it

[singerdmx]

Possibly the verticalSpacing

[ArjanAswal]

@singerdmx In the source code the 3rd parameter (which is lineSpacing) is set to Tuple2(0.0, 0.0). Then how come the newlines are so greatly spaced?

        paragraph: DefaultTextBlockStyle(
            baseStyle, baseSpacing, Tuple2(0.0, 0.0), null),

[singerdmx]

Let me double check one thing: is it between text block?

[singerdmx]

The code may be here

[ArjanAswal]

I have solved the issue by changing

Tuple2<double, double> baseSpacing = Tuple2(6.0, 10);

to:

Tuple2<double, double> baseSpacing = Tuple2(0, 0);

[singerdmx]

If the rendering is satisfactory (if it does not break other components), just submit it

[ArjanAswal]

Rendering is satisfactory.

I just changed all the baseSpacing styles in my personal projects (heading 1,2,3 ... paragraph, list, bold, italic, etc) to Tuple2(0, 0).
I suggest we do the same in the source code as we don't want to assign any extra line spacing ourselves and leave that to the developer or user.

Should I proceed with this?

[singerdmx]

Yes, go ahead

[singerdmx]

Can you submit it to stable branch?

[ArjanAswal]

@singerdmx I only changed the baseSpacing of the paragraph attribute as other implementations were looking quite cramped.

[singerdmx]

Actually I think Tuple2<double, double> baseSpacing = Tuple2(6.0, 0) is better when it comes to checkbox

[singerdmx]

Tuple2(6.0, 0) macthes checkbox's style, which I think is better

[ArjanAswal]

Actually I think Tuple2<double, double> baseSpacing = Tuple2(6.0, 0) is better when it comes to checkbox

You are right baseSpacing is actually pretty much necessary for checkboxes and lists. I was testing it out recently.
That is why in the commit I only changed the baseSpacing of the paragraph.
The spacing of other attributes remains the same.

[singerdmx]

Oh I see

[singerdmx]

I submitted a5ce035
Let me know if there is any issue

[ArjanAswal]

I submitted a5ce035
Let me know if there is any issue

@singerdmx What attributes will be affected by this and to what degree?

[singerdmx]

I think it affects the spacing between text blocks

[ArjanAswal]

I actually tried manipulating this variable which you just changed in the commit.

The paragraph was looking normal and the newline character wasn't taking extra space. However, the checkboxes and the list became cramped. Hence, I only changed the paragraph spacing.

So you might wanna check that.

[singerdmx]

Cramped? hmm... it looks fine to me

[ArjanAswal]

Cramped? hmm... it looks fine to me

Maybe I was just used to the previous styling in which everything was sort of spaced out.

Also, any chance we can replace tuple with normal line height parameter? Would make things a lot simpler in my opinion.

[singerdmx]

Yes, I agree. We should replace Tuple