Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandbox resetBehaviour and resetHistory #1072

Closed
Gudahtt opened this issue Jun 23, 2016 · 2 comments · Fixed by #1074
Closed

Sandbox resetBehaviour and resetHistory #1072

Gudahtt opened this issue Jun 23, 2016 · 2 comments · Fixed by #1074

Comments

@Gudahtt
Copy link
Contributor

Gudahtt commented Jun 23, 2016

My understanding of issue #806 is that the behaviour of reset for stubs was changed to reset both the call history and the stub behaviour. It was decided that reset would reset both, resetHistory would reset just the call history, and resetBehaviour would reset just the stub behaviour.

It would be very convenient for me if these two functions, resetHistory and resetBehaviour, were made available through the sandbox API. That is, I would like them to be added to lib/sinon/collections.js alongside reset so that you could reset the history or behaviour of an entire sandbox at once.

Thoughts?
@mantoni
Copy link
Member

mantoni commented Jun 23, 2016

That sounds perfectly reasonable. Care to make it a pull request?

@Gudahtt
Copy link
Contributor Author

Gudahtt commented Jun 23, 2016

Sure! Will do.

@Gudahtt Gudahtt mentioned this issue Jun 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add resetBehavior and resetHistory to sandbox API
2 participants
@mantoni @Gudahtt