Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sist2 web UI localization #180

Open
simon987 opened this issue Sep 4, 2021 · 16 comments
Open

sist2 web UI localization #180

simon987 opened this issue Sep 4, 2021 · 16 comments
Labels
help wanted Extra attention is needed web Web module

Comments

@simon987
Copy link
Collaborator

simon987 commented Sep 4, 2021

Reply to this issue if you would like to help me add more languages for the sist2 web UI!

The currently supported languages are:

  • en English
  • fr French
  • zh-CN Simplified Chinese
  • de German
  • pl Polish
@simon987 simon987 added help wanted Extra attention is needed web Web module labels Sep 4, 2021
@simon987 simon987 pinned this issue Sep 4, 2021
@panekj
Copy link

panekj commented Sep 5, 2021

I can help

@simon987
Copy link
Collaborator Author

simon987 commented Sep 5, 2021

@panekj Great!

Could you create a new language in https://github.com/simon987/sist2/blob/master/sist2-vue/src/i18n/messages.ts ?. You can use the pl key for Polish. The message names and correspondence in English should be pretty self-explanatory but let me know if there are any ambiguities!

@yatli
Copy link

yatli commented Jan 7, 2022

I can do zh-CN (with localized food terms of course :D).

@simon987
Copy link
Collaborator Author

simon987 commented Jan 7, 2022

I can do zh-CN.

That would be awesome!

If you want to test the changes in the web app, you can run sist2 web with the --dev argument in the root folder of the repository while sist2-vue/watch.sh (after running npm install inside sist2-vue) is running and it should update without needing to (re)compile the C binary. Let me know if you have any problems with that

@yatli
Copy link

yatli commented Jan 7, 2022

ooh, that's good to know!

@yatli
Copy link

yatli commented Jan 20, 2022

@simon987 npm install not working due to fslightbox-vue dep path hard-coded

@simon987
Copy link
Collaborator Author

npm install not working due to fslightbox-vue dep path hard-coded

Oh, right... I'm using the fslightbox-vue pro version. I don't really know any good alternatives that's why I'm using it. For now if you want to compile the web UI send me your email I can just send you the link to the tarball

@yatli
Copy link

yatli commented Jan 20, 2022

Thanks, ./watch.sh with human in the loop would be too obtrusive for you tho :D

Guess I can just remove it from package.json and remove the lightbox component...

@simon987
Copy link
Collaborator Author

Yeah I forgot about this library. In the next version I will try to use NPM's optionalDependencies thing and gracefully disable the lightbox component when it detects that the library is not installed. Ideally I should move away from fslightbox altogether but I really haven't found a good alternative that works with mobile clients yet

@yatli
Copy link

yatli commented Jan 20, 2022

Actually just remove the pro version and then npm install --save fslightbox-vue and it compiles fine. You'll only need to compile it once someone's code is checked in.

@MarioSob
Copy link

@simon987 Is the topic of Polish translation dead? I can't see it in the actual application.
I can provide such translation if you still don't have it, just let me know.

BTW: I would really like to see OCR language pre-installed in default Docker image for Polish as well.

@simon987
Copy link
Collaborator Author

simon987 commented May 10, 2023

I can provide such translation if you still don't have it, just let me know.

We don't have polish yet feel free to create a PR for this ! ❤️

OCR language pre-installed in default Docker image for Polish as well

Sure! You can create a separate PR for this by changing this command here: https://github.com/simon987/sist2/blob/master/Dockerfile#L37 for both Dockerfiles

@MarioSob
Copy link

MarioSob commented May 10, 2023

I have no rights to push my custom branch with changes to your repo:
Permission to simon987/sist2.git denied to MarioSob. fatal: unable to access 'https://github.com/simon987/sist2.git/': The requested URL returned error: 403

@simon987
Copy link
Collaborator Author

That's okay, you can create a fork under your account and try again with https://github.com/MarioSob/sist2 instead

If that doesn't work you can also just email me the modified messages.ts file at [email protected] or paste them here

@MarioSob
Copy link

I've send you an email.

@simon987
Copy link
Collaborator Author

Much appreciated @MarioSob. I added the changes in 41ef940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed web Web module
Projects
None yet
Development

No branches or pull requests

4 participants