Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

列表项块反链包含逻辑问题和引用计数问题 #571

Closed
deerainw opened this issue Nov 24, 2020 · 6 comments
Closed

列表项块反链包含逻辑问题和引用计数问题 #571

deerainw opened this issue Nov 24, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@deerainw
Copy link

deerainw commented Nov 24, 2020

某些反向链接既出现在了「链接」里,也出现在了「提及」里(链接的摘要文字又被搜索了一遍),应该是 bug。

折腾了几天这个问题,没找出复现规律,姑且先提一下。

@88250
Copy link
Member

88250 commented Nov 24, 2020

方便截图的话麻烦截个图,谢谢。

@deerainw
Copy link
Author

deerainw commented Nov 24, 2020

@88250

试了半天,现在终于可以截图了,这不是必现 bug


image


image


第一次发现这个问题是在导入 Obisidian 笔记文件夹的时候,后来发现直接在思源里创建的文件也会有这个问题

@88250
Copy link
Member

88250 commented Nov 24, 2020

这个是因为链接里的是列表项块,提及那里是列表块。逻辑上他们存在包含关系,不是相同的。

这个点我们再考虑一下,排除掉应该更合理。

@deerainw
Copy link
Author

@88250

那这种包含关系确实该处理一下,不仅仅是在反向链接面板里

再上一个能反映这种包含关系带来的问题的截图:

image

缺点.md 这个文件里只有一个无序列表,无序列表本来只有 3 项,每项里面都含有一个链接。按照这种包含逻辑,局部关系图里直接出现了整整 6 条连在列表块上的线条,并且那 3 条链接线被认为是从列表块上引出来的,但这 3 条线更应该被连接在 3 个列表项块上面

@88250
Copy link
Member

88250 commented Nov 24, 2020

谢谢指出,后续进行改进。

@88250 88250 self-assigned this Dec 6, 2020
@88250 88250 changed the title 反向链接重复出现 列表项块反链包含逻辑问题 Dec 16, 2020
@88250 88250 added the Bug label Dec 16, 2020
@88250 88250 changed the title 列表项块反链包含逻辑问题 列表项块反链包含逻辑问题和引用计数问题 Dec 17, 2020
@88250 88250 added this to the 0.5.41 milestone Dec 17, 2020
@88250
Copy link
Member

88250 commented Dec 17, 2020

修复了一下,应该稍微符合直观了:

image

image

@88250 88250 closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants