Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV output fails with league/csv 8.2 #9

Closed
rogerdawkins opened this issue Jan 7, 2019 · 8 comments
Closed

CSV output fails with league/csv 8.2 #9

rogerdawkins opened this issue Jan 7, 2019 · 8 comments
Assignees
Labels

Comments

@rogerdawkins
Copy link

Just upgraded to 2.1.1 and using league/csv 8.2 for compatibility with FeedMe but it fails with:

Call to undefined method League\Csv\Writer::getContent()

in BeamService.php on line 69.

getContent I believe was added in league/csv 9.1 which would explain why it fails.

@codyjames
Copy link

I'm getting this issue as well.

@sjelfull
Copy link
Owner

sjelfull commented Jan 8, 2019

Doh, I added it too quickly.

I'll see if I can get Feed Me to upgrade it on their end.

@codyjames
Copy link

@sjelfull Yeah, I think that is the way to go.

@codyjames
Copy link

I had to downgrade beam to 2.0.0 in order to use Feed Me and Beam at the same time.

@wbrowar
Copy link
Contributor

wbrowar commented Jan 14, 2019

@nystudio107 also uses league/csv 8.2 for nystudio107/craft-retour, and that's actually where my issue comes from. Is it possible to fall back to the 8.x version methods if 9.x isn't installed or does the new setup prevent that?

@sjelfull sjelfull self-assigned this Jan 15, 2019
@sjelfull sjelfull added the bug label Jan 15, 2019
@sjelfull
Copy link
Owner

Can't remember if I need anything that isn't in 8.2. I have to take a look at it once I have a moment.

@rogerdawkins
Copy link
Author

You would need changes to go back to 8.2 for CSV as you use League\Csv\Writer::getContent()

in BeamService.php on line 69.

getContent I believe was added in league/csv 9.1.

@sjelfull
Copy link
Owner

Tagged release with check that hopefully allows both versions to be used.

It basically checks if getContent is available, and if not fall backs to using __toString().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants